C#: Add path arg validation to Signer & Verifier

.github/workflows/csharp.yml

@@ -3,8 +3,14 @@ name: C#
 on:
   push:
     branches: [ main ]
+    paths:
+      - 'csharp/**'
+      - 'test-resources/**'
   pull_request:
     branches: [ main ]
+    paths:
+      - 'csharp/**'
+      - 'test-resources/**'
 
 jobs:
   test:

.github/workflows/go.yml

@@ -3,8 +3,14 @@ name: Go
 on:
   push:
     branches: [ main ]
+    paths:
+      - 'go/**'
+      - 'test-resources/**'
   pull_request:
     branches: [ main ]
+    paths:
+      - 'go/**'
+      - 'test-resources/**'
 
 jobs:
   lint:

.github/workflows/java.yml

@@ -2,10 +2,17 @@ name: Java
 
 on:
   push:
-    branches:
-      - '**'
+    branches: [ main ]
+    paths:
+      - 'java/**'
+      - 'test-resources/**'
     tags-ignore:
       - '**'
+  pull_request:
+    branches: [ main ]
+    paths:
+      - 'java/**'
+      - 'test-resources/**'
 
 jobs:
   build-and-test:

.github/workflows/node.yml

@@ -3,8 +3,14 @@ name: Node
 on:
   push:
     branches: [ main ]
+    paths:
+    - 'nodejs/**'
+    - 'test-resources/**'
   pull_request:
     branches: [ main ]
+    paths:
+    - 'nodejs/**'
+    - 'test-resources/**'
 
 jobs:
   test:

.github/workflows/php.yml

@@ -5,8 +5,14 @@ on:
     branches: [ main ]
     tags:
       - "php/v**"
+    paths:
+      - 'php/**'
+      - 'test-resources/**'
   pull_request:
     branches: [ main ]
+    paths:
+      - 'php/**'
+      - 'test-resources/**'
 
 jobs:
   test:
@@ -72,4 +78,4 @@ jobs:
           path: "php"
           deploy_key: ${{ secrets.DOWNSTREAM_GITHUB_DEPLOY_KEY }}
           branch: ${{ steps.tag-replacer.outputs.NEW_TAG }}
-          force: true
+          force: true

.github/workflows/rust.yml

@@ -3,8 +3,14 @@ name: Rust
 on:
   push:
     branches: [ main ]
+    paths:
+    - 'rust/**'
+    - 'test-resources/**'
   pull_request:
     branches: [ main ]
+    paths:
+    - 'rust/**'
+    - 'test-resources/**'
 
 jobs:
   test:

csharp/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.1.10
+* Add `path` arg validation to `Signer` & `Verifier` for more informative errors.
+
 ## 0.1.9
 * Fix key-dependant parameter length error for .NET Standard 2.0.
 

csharp/src/Signer.cs

@@ -60,6 +60,10 @@ public Signer Method(string method)
         /// </summary>
         public Signer Path(string path)
         {
+            if (!path.StartsWith("/"))
+            {
+                throw new ArgumentException($"Invalid path \"{path}\" must start with '/'");
+            }
             this.path = path;
             return this;
         }

csharp/src/Verifier.cs

@@ -112,6 +112,10 @@ public Verifier Method(string method)
         /// </summary>
         public Verifier Path(string path)
         {
+            if (!path.StartsWith("/"))
+            {
+                throw new ArgumentException($"Invalid path \"{path}\" must start with '/'");
+            }
             this.path = path;
             return this;
         }

csharp/src/truelayer-signing.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <PackageVersion>0.1.9</PackageVersion>
+    <PackageVersion>0.1.10</PackageVersion>
     <TargetFrameworks>net5.0;netstandard2.0;netstandard2.1</TargetFrameworks>
     <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
     <Nullable>enable</Nullable>

csharp/test/ErrorTest.cs

@@ -129,5 +129,25 @@ string CreateSignature(Dictionary<string, string> jwsHeaderMap)
 
             verify.Should().Throw<SignatureException>();
         }
+
+        [Fact]
+        public void InvalidSignerPath()
+        {
+            Action sign = () => Signer.SignWithPem(Kid, PrivateKey)
+                .Path("https://example.com/the-path");
+
+            sign.Should().Throw<ArgumentException>()
+                .WithMessage("Invalid path \"https://example.com/the-path\" must start with '/'");
+        }
+
+        [Fact]
+        public void InvalidVerifierPath()
+        {
+            Action verify = () => Verifier.VerifyWithPem(PublicKey)
+                .Path("https://example.com/the-path");
+
+            verify.Should().Throw<ArgumentException>()
+                .WithMessage("Invalid path \"https://example.com/the-path\" must start with '/'");
+        }
     }
 }