Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hickory-dns #61

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Use hickory-dns #61

merged 3 commits into from
Dec 9, 2024

Conversation

tl-rodrigo-gryzinski
Copy link
Contributor

In October 2023, trust-dns was rebranded to hickory, this incldued changing the crate names, trust-dns-resolver is unmaintained. See the project README https://github.com/bluejekyll/trust-dns?tab=readme-ov-file#trust-dns

@tl-rodrigo-gryzinski tl-rodrigo-gryzinski requested a review from a team as a code owner December 9, 2024 14:10
@@ -6,6 +6,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
tonic_build::configure()
.build_server(true)
.build_client(true)
.compile(&["proto/test.proto", "proto/echo.proto"], &["proto/"])?;
.compile_protos(&["proto/test.proto", "proto/echo.proto"], &["proto/"])?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile is deprecated

ThomWright
ThomWright previously approved these changes Dec 9, 2024
Copy link
Member

@ThomWright ThomWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tl-rodrigo-gryzinski tl-rodrigo-gryzinski merged commit 1b31252 into main Dec 9, 2024
6 checks passed
@tl-rodrigo-gryzinski tl-rodrigo-gryzinski deleted the switch-to-hickory branch December 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants