-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🥁 Update the gnosis safe api url #1152
Open
robotoer
wants to merge
2
commits into
TrueFiEng:master
Choose a base branch
from
term-finance:fix-gnosis-url
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address used to access the gnosis safe API changed in 2023: https://forum.safe.global/t/announcement-to-all-builders-using-safe-services/3225
🦋 Changeset detectedLatest commit: a38f382 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
For those looking for an immediate solution, try using https://www.npmjs.com/package/patch-package with the following patch file ( diff --git a/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js b/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js
index 3cfe0e3..9221651 100644
--- a/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js
+++ b/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js
@@ -55,7 +55,7 @@ exports.calculateSafeTransactionHash = calculateSafeTransactionHash;
const getLatestNonce = async (chainId, safeAddress) => {
var _a, _b, _c;
try {
- const response = await fetch(`https://safe-transaction.${(_a = (0, chain_1.getChainById)(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.gnosis.io/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
+ const response = await fetch(`https://safe-transaction-${(_a = (0, chain_1.getChainById)(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.safe.global/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
if (!response.ok)
return null;
const allTransactions = await response.json();
diff --git a/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js b/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js
index 00440be..20242f1 100644
--- a/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js
+++ b/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js
@@ -46,7 +46,7 @@ export const calculateSafeTransactionHash = (safe, safeTx, chainId) => {
export const getLatestNonce = async (chainId, safeAddress) => {
var _a, _b, _c;
try {
- const response = await fetch(`https://safe-transaction.${(_a = getChainById(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.gnosis.io/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
+ const response = await fetch(`https://safe-transaction-${(_a = getChainById(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.safe.global/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
if (!response.ok)
return null;
const allTransactions = await response.json();
diff --git a/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts b/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts
index 3225279..c4db3b6 100644
--- a/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts
+++ b/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts
@@ -88,9 +88,9 @@ export const calculateSafeTransactionHash = (
export const getLatestNonce = async (chainId: number, safeAddress: string): Promise<number | null | undefined> => {
try {
const response = await fetch(
- `https://safe-transaction.${
+ `https://safe-transaction-${
getChainById(chainId)?.chainName
- }.gnosis.io/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`
+ }.safe.global/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`
)
if (!response.ok) return null
const allTransactions = await response.json() |
nezouse
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address used to access the gnosis safe API changed in 2023: https://forum.safe.global/t/announcement-to-all-builders-using-safe-services/3225