Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic update to userAddress auth-context state value #282

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

johngribbin
Copy link
Collaborator

  • Up until now the default value for user address has been the string value none,
  • This is used by many components to assess if the user was logged in or not.
  • With this change, the default is now undefined (type undefined) and the components that utilize the userAddress value (conditional rendering etc) have all been updated to recognize this change
  • This change not only makes the code more legible but I believe it is just a better practice

@johngribbin
Copy link
Collaborator Author

@Kmoneal Does changing the default state of userAddress from "none" to undefined cause any breaking changes on the backend? If not, i'd like to merge this change. Not a huge priority though, so if it does cause any hassle on backend - we can delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant