Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R3dev.chris #83

Closed
wants to merge 11 commits into from
Closed

R3dev.chris #83

wants to merge 11 commits into from

Conversation

interplanetarychris
Copy link
Contributor

@Kmoneal Noticed that a few of the changes we made during deployment week aren't actually running on master - the hard coded object 39462 as well as the minor table correction from Obs.obs_id to P.obs_id as two examples.

There are a number of additional functions which I am using with satfit.py, but don't apply to the front-end.

This code should be deployed to Production after your review.

@interplanetarychris
Copy link
Contributor Author

It looks like incorporating this code would address Issue #82

@interplanetarychris interplanetarychris added the bug Something isn't working label Dec 9, 2019
Copy link
Collaborator

@Kmoneal Kmoneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you rebase this? If you prefer me to rebase it, please let me know

@Kmoneal Kmoneal mentioned this pull request Jan 13, 2020
@Kmoneal
Copy link
Collaborator

Kmoneal commented Jan 13, 2020

Resolved in PR #88

@Kmoneal Kmoneal closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants