Issue 592 : support service meta data #593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade consul api to ~1.9.0 - upgrade prometheus api to 1.1.0 - fix integration test - run build with current user uuid/gid so we don't have root owned files which breaks make clean - add meta to docs
- cleanup run.sh
teutat3s
added a commit
to greenbaum/containerpilot
that referenced
this pull request
Oct 25, 2022
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <[email protected]>
This was referenced Oct 25, 2022
teutat3s
added a commit
to greenbaum/containerpilot
that referenced
this pull request
Nov 9, 2022
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <[email protected]>
teutat3s
added a commit
to greenbaum/containerpilot
that referenced
this pull request
Nov 9, 2022
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation for service meta data support as described in issue 592
for this i needed to upgrade build dependency to
upgrades are limited to this version because build is still using glide instead of go modules. for further upgrades of prometheus, we need go module migration, which is out of scope for this issue.
this includes some fixes/api changes required in unit/integration testing because of upgraded api's
for testing run
make test
make integration
test are updated to check & validate service.meta data.
make lint complains about "events.Event composite literal uses unkeyed fields" but haven't change anything around events.