Skip to content

Conversation

eliandoran
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 11, 2025

📚 Website preview is ready!

🔗 Preview URL: https://pr-7277.trilium-homepage.pages.dev
📖 Production URL: https://triliumnotes.org

✅ All checks passed

This preview will be updated automatically with new commits.

@eliandoran eliandoran marked this pull request as ready for review October 13, 2025 16:23
@eliandoran
Copy link
Contributor Author

/gemini review

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 13, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces internationalization support for the website using i18next, which is a great addition. The implementation covers adding dependencies, creating the initial English translation file, and updating components to use translation functions.

However, there are a few critical issues with the current implementation. The i18next setup in i18n.ts will not work as expected in a reactive framework like Preact, as it won't trigger UI updates on language change. This also leads to issues in files like download-helper.ts where translations are cached at module load time. I've also found a couple of bugs, such as a missing variable in a translation call and a wrong translation key being used.

My review includes detailed comments on these issues and suggestions for how to fix them by adopting standard react-i18next patterns, like using the useTranslation hook. Addressing these points will ensure the translation system is robust and works correctly.

@eliandoran eliandoran merged commit 016ba1e into main Oct 13, 2025
10 checks passed
@eliandoran eliandoran deleted the feat/website_intl branch October 13, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant