Feat/clean share url #5832
Open
Feat/clean share url #5832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st time using Meld. I'm not sure if the conflict resolve is clean
commented out for now, to make sure we get back to it – not sure if it was suppossed to have any special other reason to exist
caused by having other several save operation inside the save() method (which doesn't even make sense to begin with, as far as I can tell) moving it to inside the "change" event handler allows us to set and store a custom share path again
there's no need to execute PUT requests for *all* Share Settings, when any option changes moved the code to inside the "change" event handlers
…rectBareDomain change → that is what the shareRootCheck button is there for
…g new local $button variable
* add rudimental error handling * add handling of special case, where one has multiple shared notes with a #shareRoot label * refactor styling into auxiliary setCheckShareRootStyle function
* add normalization helper to ensure string does not start with multiple trailing slashes or ends with a trailing slash * fall back to default "/share" when empty string is entered
it currently fails trying to import the class though a "manual" importing of the function did pass all checks though -> will need to investigate why importing the class does not work like that
that should be part of a later PR
normalization is happening in the share settings options widget in the meantime, making it more obvious to the user
that should be part of a later PR
needs to currently mention, that a server restart is required
…working this will be handled by cleanUrl PR later on
that should be part of a later PR
dosubot
bot
added
the
size:XL
dosubot
bot
added
BE
JYC333
force-pushed
the
feat/clean-share-url
branch
from
cf661c1 to
519b964
Compare
|
@eliandoran This is ready for reivew. @pano9000 FYI, if you have time would like to check it also. |
|
Really looking forward to this feature, I'm assuming it's also going to fix the current state of "Redirect bare domain to Share page" not working as intended? |
|
📚 Documentation preview is ready! 🔗 Preview URL: https://pr-5832.trilium-docs.pages.dev ✅ All checks passed This preview will be updated automatically with new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of TriliumNext/Notes#1781.