Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are quite a few bugs when using GitHub Actions along with
node:alpine
andarmv7
/armv6
builds. This includes the following issues:docker/build-push-action#1071
docker/build-push-action#977
nodejs/docker-node#2077
I also tried some of the workarounds listed in the above issues, but instead got really strange errors:
I split the container into the "build step" using Node v18, and then changed to use the "run step" at Node v20, copying over the node modules, etc., and the above error popped up every time.
So the next best option that I found was to instead use node's slim Debian container instead, so that we could at least get ARM builds out the door. We will have to drop ARMv6 compatibility, but instead we can then add ARM64v8 builds.
I know that Debian's slim containers are larger than Alpine's, but at least we can then have ARMv7 / ARM64v8.
I also had to change the
su-exec
command in thestart-docker.sh
to usegosu
instead because we're using Debian.