Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphql): Update ts-morph peer dependency versions to prevent error on install #360

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

pevey
Copy link
Contributor

@pevey pevey commented Feb 17, 2025

Update package.json to add more allowed versions of ts-morph peer dependency versions to prevent error on install

@TriPSs
Copy link
Owner

TriPSs commented Feb 17, 2025

Does it actually work with those versions?

Copy link

nx-cloud bot commented Feb 17, 2025

View your CI Pipeline Execution ↗ for commit 4b96a16.

Command Status Duration Result
nx run-many --target=e2e --all ✅ Succeeded 2m 40s View ↗
nx run-many --target=test --all ✅ Succeeded 2m 51s View ↗
nx run-many --target=lint --all ✅ Succeeded 45s View ↗
nx run-many --target=build --all ✅ Succeeded 12s View ↗
nx run workspace:version ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-17 17:55:28 UTC

@pevey
Copy link
Contributor Author

pevey commented Feb 17, 2025

I get resolution errors when running the unit tests locally. I was hoping the github actions pipeline would run the tests to see. I've been using 25 in a project, and haven't had issues yet. @nestjs/graphql itself has a dependency of ts-morph 20+ now. By default, a new nestjs project installs ts-morph 25.

@TriPSs TriPSs merged commit e23b8fc into TriPSs:master Feb 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants