Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: coverage setup #837

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: coverage setup #837

wants to merge 4 commits into from

Conversation

alvarosabu
Copy link
Member

No description provided.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 9dda5cf
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/66f6af66badde50008423b05
😎 Deploy Preview https://deploy-preview-837--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alvarosabu ,

Thanks for looking into this.

For me, after adding the changes here, no tests run.

I've appended changes to vite.config.ts that work for me locally.

Do they work for you?

@@ -44,9 +44,13 @@ export default defineConfig({
Inspect(),
],
test: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the setup in this PR, 0 tests are run after pnpm test:ui.

Tests run using the following config, which also excludes playground, docs and **/sponsorkit**/** from coverage:

import { coverageConfigDefaults } from 'vitest/config'
  test: {
    environment: 'jsdom',
    globals: true,
    coverage: {
      provider: 'v8',
      exclude: [
        ...coverageConfigDefaults.exclude,
        'playground/**',
        'docs/**',
        '**/sponsorkit**/**',
      ],
    },
  },

Taken from here: Vitest coverage.exclude docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andretchen0 for me they work, but I updated the config with your suggestion

Copy link

pkg-pr-new bot commented Sep 18, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@tresjs/core@837

commit: 3b87ba1

@alvarosabu alvarosabu added the p1-chore Doesn't change end-user code behavior (priority) label Sep 27, 2024
@alvarosabu
Copy link
Member Author

Hi @andretchen0 I added your suggestion, is it good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change end-user code behavior (priority)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants