-
Notifications
You must be signed in to change notification settings - Fork 0
MOB-1679 Update to latest SDKs. Add latest APIs #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project to the latest SDKs and introduces several new APIs for handling authentication workflows across web, native biometrics, and PIN code strategies. Key changes include the refactoring of the local user store for managing user IDs and PIN status, the addition of new approval and authentication methods in both the React and native modules, and extensive updates to dependency versions and project configuration files for iOS and Android.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
example/src/utils/local-user-store.ts | Refactored storage structure to include both userIDs and PIN statuses and updated JSON parsing logic. |
example/src/App.tsx | Added new state management (loading) and integrated new authentication/approval API methods. |
example/package.json | Updated dependency versions and added new packages for improved compatibility. |
example/ios/* | Updated project configuration, added privacy information, and modified storyboard and AppDelegate settings. |
example/android/* | Upgraded Gradle, updated build scripts, and revised dependency versions (including TS SDK version update). |
android/src/main/java/com/tsauthentication/TsAuthenticationModule.java | Extended module functionality with new methods for WebAuthn, native biometrics, and PIN code support. |
README.md | Revised documentation to include usage examples for the new approval and PIN code APIs. |
Comments suppressed due to low confidence (1)
example/ios/Podfile:13
- [nitpick] If the commented-out workaround is no longer needed, consider removing it to reduce clutter and improve file readability.
#
} | ||
|
||
public hasRegisteredPIN = (userID: string): boolean => { | ||
console.log('Checking PIN status for user:', userID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing or replacing debug console.log statements with a proper logging mechanism to avoid leaking potentially sensitive information in production.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Rimmassukhovsky,
Can you please review this file when you get a chance? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @igorbabitski ,
Can you please review this file when you get a chance? Thank you!
No description provided.