Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android mob 787 #1

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Android mob 787 #1

merged 3 commits into from
Jan 3, 2024

Conversation

Ran-Stone
Copy link
Contributor

Fix react native android plugin

Verified

This commit was signed with the committer’s verified signature.
cozej4 Ilakoze Jumanne
Copy link
Collaborator

@shachartransmit shachartransmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
1 .Are you sure we don't need to use the main thread?
2. Do we really need to add "/" for baseURL?

@@ -188,7 +188,7 @@ export default class App extends React.Component<any, State> {
TSAuthenticationSDKModule.initialize(
appConfiguration.clientId,
appConfiguration.domain,
`${appConfiguration.baseUrl}/cis/v1`
`${appConfiguration.baseUrl}/cis/v1/`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required for android.
Does it iOs work without it? it doesn't seem to be platform specific

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember it being a problem. If you're sure about it maybe it's worth letting the dev team know. It's not expected (or documented I believe).

@shachartransmit shachartransmit merged commit 40e749e into main Jan 3, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants