Sync model_registry sets with architecture_adapter_factory and add in…#1354
Merged
jlarson4 merged 1 commit intoJun 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1350.
HF_SUPPORTED_ARCHITECTURESandCANONICAL_AUTHORS_BY_ARCHare documented to track adapters registered inarchitecture_adapter_factory.py, with internal-only adapters excluded.Qwen3MoeForCausalLMandBaichuanForCausalLMwere wired in the factory but missing from one or both registry sets, so the scraper silently classified their models as unsupported.Changes:
Qwen3MoeForCausalLM,BaichuanForCausalLM, andBaiChuanForCausalLM(Baichuan-1 casing) toHF_SUPPORTED_ARCHITECTURES.Qwen3MoeForCausalLM: ["Qwen"]andBaiChuanForCausalLM: ["baichuan-inc"]toCANONICAL_AUTHORS_BY_ARCH.TransformerLensNative(introduced in Created a system for running Native models #1353) to the named internal-only group, and explicitly name the three factory-internal alias casings (Gemma1,Neo,NeoX) that route to canonical adapters under names HF does not emit (Gemma,GPTNeo,GPTNeoX).TestRegistrySyncedWithFactory) intests/unit/tools/test_model_registry.py: every non-excluded factory key must be present in both registry sets, and every registry entry must have a matching factory adapter. While building this test, it surfacedTransformerLensNative(added in Created a system for running Native models #1353) as a third silent drift item alongside the originally-reported Qwen3-MoE and Baichuan omissions. Future adapter PRs that forget to update the registry will be flagged by this test in CI from now on.Type of change
Checklist: