Skip to content

Conversation

@varkey98
Copy link
Contributor

@varkey98 varkey98 commented Oct 7, 2025

No description provided.

@tim-mwangi
Copy link
Contributor

You should run make generate-proto generate-env-vars to get the env vars generated as well

// no sanitization check configured
SPAN_SANITIZATION_MODE_NONE = 0;

// drop the span incase sanitization panics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a customer ever prefer to drop the whole span?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only support drop for now. Otherwise we'll have to add a defer inside the loop of attribute iteration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropping should be fine. Given the impact.

@varkey98
Copy link
Contributor Author

varkey98 commented Oct 7, 2025

You should run make generate-proto generate-env-vars to get the env vars generated as well

Ran those, our generator doesnt support enums 😅

@prodion23
Copy link
Contributor

is there ticket for this? (curious of the context?)

@varkey98
Copy link
Contributor Author

varkey98 commented Oct 7, 2025

is there ticket for this? (curious of the context?)

is there ticket for this? (curious of the context?)

@prodion23 This is the original ticket: https://harness.atlassian.net/browse/ENGTAI-65822

@varkey98 varkey98 marked this pull request as ready for review October 7, 2025 15:59
@varkey98 varkey98 changed the title update protos for adding span sanitization mode ENGTAI-70889: update protos for adding span sanitization mode Oct 7, 2025
@varkey98 varkey98 changed the title ENGTAI-70889: update protos for adding span sanitization mode ENGTAI-70899: update protos for adding span sanitization mode Oct 7, 2025
@varkey98 varkey98 merged commit cac6c25 into main Oct 7, 2025
1 check passed
@varkey98 varkey98 deleted the span-sanitization-config branch October 7, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants