Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to force players to either Plunder or Invade a Town #927

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

ouckah
Copy link
Contributor

@ouckah ouckah commented Aug 27, 2024

Description:

This pull request aims to add an option to force players to either plunder or invade a nation. This is due to a possible exploit to plunder a nation and then invade them and tax them tons.


New Nodes/Commands/ConfigOptions:

New Config Option: war.siege.switches.only_one_action_enabled
  - Default: false
  - If true, players can only either invade or plunder a town, not both.
  - If false, players can perform both actions.

Relevant Issue ticket:

Closes #922


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@LlmDl LlmDl changed the title Add Option to force players to either Plunder or Invade a Nation Add Option to force players to either Plunder or Invade a Town Aug 27, 2024
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to be missing the lang strings:

msg_err_town_already_plundered_only_one_action
msg_err_town_already_invaded_only_one_action

@ouckah
Copy link
Contributor Author

ouckah commented Aug 28, 2024

@LlmDl added, are there any other config files that have to be updated?

Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other changes are needed thank you.

@LlmDl LlmDl added this to the 2.14.0 milestone Aug 28, 2024
@ouckah
Copy link
Contributor Author

ouckah commented Aug 28, 2024

Tested and it's good to go! Thank you @LlmDl!

@LlmDl LlmDl merged commit 6830bb7 into TownyAdvanced:master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Add a config option that forces users to choose between a plunder and capture, not both
2 participants