Add MapTowny integration! #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Functionally the same as the Dynmap / Dynmap-Towny integration. - Uses code from the Dynmap Integration to display siege icon markers. - Add a specific fire icon to use for MapTowny and attribution for the icon in the README.
|
Thanks so much for adding this! Huzzah!!!. |
Goosius1
requested changes
Apr 28, 2022
src/main/java/com/gmail/goosius/siegewar/integration/maptowny/MapTownyIntegration.java
Outdated
Show resolved
Hide resolved
|
I mentioned this to @silverwolfg11 in #towny-dev as well but it ought to go here too: the formatting on the existing files will have to be undone too. He says this is a bit of a proof of concept first, while he considers what other API needs to be added to MapTowny. |
|
Fixed the line endings and made the map change to be triggered the NewShortTimeEvent instead of a fixed interval. |
Goosius1
reviewed
May 1, 2022
|
|
||
| @EventHandler | ||
| public void onNewShortTime(NewShortTimeEvent event) { | ||
| this.renderSieges.run(); |
There was a problem hiding this comment.
🚧
- Have I missed something, or is threading unnecessary here?
- Couldn't we just do something un-threaded like: SiegeWar.getMapTownyIntegration().displaySieges() ?
|
Hi Silverwolf, what is the status of this PR? |
|
Hi @silverwolfg11 , what is the status of this PR? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR aims to integrate MapTowny with SiegeWar!
The MapTowny integration is functionally the same as the Dynmap / Dynmap-Towny integration and copies some code from the integration as well.
Since MapTowny works with various platforms, there were no default icons, so a fire icon had to be added into the jar to render it on the map. This icon is licensed with attribution, so attribution was added to the README.
New Nodes/Commands/ConfigOptions:
N/A
Relevant Issue ticket:
#283
Tested on a local testing server with an incomplete siege. Would appreciate if people with more experience with SiegeWar and/or players test this as well.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.