feat(redis): redis adapter crate #402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Sync bound on adapter error * Add an AdapterCtr trait to keep state
This will allow adapter implementors to use the `LocalAdapter` as a parent.
This will allow to share errors between nodes. The parser error is also now a Boxed error in order to have multiple dyn possible implementations;
Totodore
changed the title
Open
Totodore
force-pushed
the
redis-adapter
branch
from
fca7334 to
8e03927
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Change the error type for `broadcast_with_ack` and `disconnect`. Now it is a `BroadcastError` that handle all error cases.
Totodore
force-pushed
the
redis-adapter
branch
from
429f3a0 to
02f9485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a redis adapter crate.
Close issue #396.
Solution
The redis adapter crate (named
socketioxide-redis) will implement thesocketioxide_core::CoreAdaptertrait provided with the PR #395.As there are many pub/sub redis implementation in the rust ecosystem, the crate will be agnostic from the implementation. A simple
Drivertrait will be available to implement custom redis client crates. By defaultsocketioxide-rediswill propose an implementation for :