Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cmake depends #1347

Merged

Conversation

marauder2k7
Copy link
Contributor

Other projects were unable to find our builds of dependencies eg. Assimp and Zlib. We were previously doing this through a hacky set so that assimp wouldnt look for the project now we use what cmake calls modules.

Since we already have modules and they do something different i have added these to a folder just called finders. When any other project calls find_pacakge these findXXX.cmake files will get called instead and will return our target for the libs. Known dependencies throughout the build at the moment are:
Zlib
Flac
Ogg
Vorbis
Opus.

Now these will be found through these modules and stop the wishful auto target linking that we were using before and now it will report that it finds the requirements.

@Azaezel Azaezel merged commit 0f4b042 into TorqueGameEngines:development Jan 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants