Image asset refactor - For 4.2 #1343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start of attempt 3
bitmap button popup ctrl ex
moved error printout in guiType guiControlProfile incLoadCount inside a check to make sure the profile has a bitmap asset set. remove older typeImageAssetId from group and variable inspector classes
basicClouds refactored null dereference fixes in guiMenuBar
changing the beast over to the refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All classes using image assets now go throught the image asset for the resource, before each class had a GFXTexHandle attached to them through the macros.
TypeImageAssetPtrRefactor replaces TypeImageAssetPtr and TypeImageAssetId for the script interfacing.
@todo:
NamedTarget support (either as its own asset or part of imageAsset)
CubemapData and PostEffect - these 2 classes seem to be the main reason the macros grew to the size they did.