[WIP] improve carry recycling #403

kahojyun · 2017-09-10T19:04:19Z

The main point of this commit is improving energy harvest efficiency.

Improved the way to check extra carries. Carries will be recycled if they are waiting for sourcer.
Before recycling carries with a spawn, check spawn queue and assign a new target to carry.
Sourcers calculate spawn rate depending on resourceAtPostion.
Added an option to switch on/off energy transfer between carries. It's turned off by default.
Modified spawn priority for reserver and carry.

With this improvement, carries will work more efficiently. Tested on the official server:

Stored about 900k energy in storage before upgrading to RCL6. (five sources in extern room)

samogot

I like the idea, but implementation seems to be a bit hackish. I'd like to avoid carry- or whatever role -specific logic in common code. At least avoid new such code if possible)
Also make sure you won't recycle last carry for target

samogot · 2017-09-14T21:18:41Z

src/prototype_creep_harvest.js

@@ -63,15 +63,22 @@ Creep.prototype.spawnCarry = function() {
    resourceAtPosition += _.sum(container.store);
  }

+  const waitTime = carryCapacity / (HARVEST_POWER * workParts) *
+    Math.sqrt(carryCapacity / Math.max(resourceAtPosition, carryCapacity));


samogot · 2017-09-14T21:28:00Z

src/prototype_creep_routing.js

@@ -267,6 +267,10 @@ Creep.prototype.moveByPathMy = function(route, routePos, start, target, skipPreM
        if (this.memory.killPrevious) {
          this.killPrevious();
        }
+        if (this.memory.checkRecycle && this.isStuck() && !this.memory.routing.reverse) {


I do not like it. carry may stuck not only because of lack of resources at sourcer
either way, name recycleOnStuck would be better then checkRecycle

maybe we may move it to carries pre-move?

It's a little bit tricky to move this to pre-move because I need to use path.length. Maybe we can store path.length in creeps' memory.

we can pass it the same way as directions

samogot · 2017-09-14T21:29:48Z

src/prototype_creep.js

@@ -63,7 +63,7 @@ Creep.prototype.handle = function() {
    return;
  }

-  if (this.memory.recycle) {
+  if (this.memory.recycle && this.memory.moveToSpawn) {


do not like it at all. creep.memory.recycle meant to be universal and easily to set manually from interface, if we need it

samogot · 2017-09-14T21:38:08Z

src/role_carry.js

+        }
+      }
+      if (roles.carry.checkOnPathStart(creep)) {
+        creep.memory.moveToSpawn = true;


it's better to handle carries pre-recycle logic with another memory flag, and set recycle flag here

you're right, I'll use resetTarget for pre-recycle logic

TooAngel · 2017-09-10T21:03:25Z

src/prototype_creep_harvest.js

@@ -63,15 +63,22 @@ Creep.prototype.spawnCarry = function() {
    resourceAtPosition += _.sum(container.store);
  }

+  const waitTime = carryCapacity / (HARVEST_POWER * workParts) *
+    Math.sqrt(carryCapacity / Math.max(resourceAtPosition, carryCapacity));


I like the approach, can you explain a bit more what the idea is here?

Reduce waitTime according to resourceAtPosition. I use Math.sqrt in the hope that it will reach an equilibrium quickly (not call/spawn too much carries).

K, cool, let's see

TooAngel · 2017-09-10T21:04:35Z

src/prototype_creep_harvest.js

+  }
+
+  // low minSpawnRate helps carry recycling
+  let minSpawnRate = 10;


Extract it to the config

kahojyun · 2017-09-15T13:40:21Z

src/config.js

+    // when ticksToLive > recycleThreshold, reuse carry
+    recycleThreshold: 200,
+    // keep at least one carry for a target
+    ensureOne: true,


I couldn't think up a better name...

I think it is fine, maybe ensureOnePerTarget ... :-)

kahojyun · 2017-09-15T13:43:00Z

src/prototype_creep_harvest.js

+  if (baseRoom.controller.level < 4) {
+    this.memory.wait = Math.max(waitTime, config.carry.minSpawnRate);
+  } else {
+    this.memory.wait = waitTime;


Normally, waitTime won't get too small because of Math.sqrt.

TooAngel · 2017-09-17T20:00:12Z

src/config.js

@@ -139,7 +139,13 @@ global.config = {
      1800: [8, 15], // RCL 5
      2300: [11, 21], // RCL 6
    },
+    transferToCarry: false,


Not sure what the intention is.

The default behavior should be that carries transfer to carries. If I understand the implementation correct, that would be disabled here.
And there are two methods, something like transferToCreep which actually transferrs and something like checkForTransfer which lets the carry move in the other direction because it will get energy in this tick.

Both needs to be adapted.

Maybe we can swap carries' target when they transfer to each other.

TooAngel · 2017-09-17T20:05:56Z

src/role_carry.js

@@ -164,6 +192,35 @@ roles.carry.preMove = function(creep, directions) {
  }

  reverse = creep.pickupWhileMoving(reverse);
+
+  // recycle carry


I do not like the recycling idea sooo much.

If there is a problem with too many carries, the call carry logic should be improved.
But fine until the call carry logic is better.

The ultimate solution to call carry logic would be #294. My solution is making use of 'negative feedback'. The latter one is not as efficient as the former one, but it's easier to be implemented, and, in my opinion, their performance difference is not quite significant.

I'm fine with adding this one and I'm also not so sure about the perfect solution, especially due to the fact that paths should be shared over multiple sources, which makes it more tricky.

- move codes related to carry recycling into `role_carry.js` - add an option of keeping at least one carry for a target - normally carry spawn rate won't get too fast because `Math.sqrt` is used

- fixed pickupWhileMoving. carry might move back and forth next to sourcer - ensureOne: exclude creeps that have `resetTarget` flag

TooAngel · 2017-09-20T19:17:52Z

src/config.js

+    // when ticksToLive > recycleThreshold, reuse carry
+    recycleThreshold: 200,
+    // keep at least one carry for a target
+    ensureOne: true,


I think it is fine, maybe ensureOnePerTarget ... :-)

TooAngel · 2017-09-20T19:18:13Z

src/prototype_creep_harvest.js

@@ -63,15 +63,22 @@ Creep.prototype.spawnCarry = function() {
    resourceAtPosition += _.sum(container.store);
  }

+  const waitTime = carryCapacity / (HARVEST_POWER * workParts) *
+    Math.sqrt(carryCapacity / Math.max(resourceAtPosition, carryCapacity));


K, cool, let's see

TooAngel · 2017-09-20T19:21:02Z

src/prototype_creep_resources.js

@@ -106,7 +99,7 @@ Creep.prototype.pickupWhileMoving = function(reverse) {
  if (resources.length > 0) {
    const resource = resources[0];
    const amount = this.pickupOrWithdrawFromSourcer(resource);
-    return _.sum(this.carry) + amount > 0.5 * this.carryCapacity;
+    return this.checkEnergyTransfer(amount);


TooAngel · 2017-09-20T19:28:29Z

src/role_carry.js

@@ -164,6 +192,35 @@ roles.carry.preMove = function(creep, directions) {
  }

  reverse = creep.pickupWhileMoving(reverse);
+
+  // recycle carry


I'm fine with adding this one and I'm also not so sure about the perfect solution, especially due to the fact that paths should be shared over multiple sources, which makes it more tricky.

Nevrdid · 2017-09-21T04:12:11Z

might have a look at my https://screeps.com/a/#!/room/shard1/W31N49 room. got a pretty good result with my amount calculation and creeps modifs.

kahojyun mentioned this pull request Sep 11, 2017

bug fix #393

Merged

samogot suggested changes Sep 14, 2017

View reviewed changes

TooAngel reviewed Sep 14, 2017

View reviewed changes

kahojyun changed the title ~~improve carry recycling~~ [WIP] improve carry recycling Sep 15, 2017

ghost added the WIP label Sep 15, 2017

kahojyun commented Sep 15, 2017

View reviewed changes

TooAngel reviewed Sep 17, 2017

View reviewed changes

kahojyun added 3 commits September 18, 2017 14:28

improve carry recycling

39e7cb0

some improvement

d33cc1b

- move codes related to carry recycling into `role_carry.js` - add an option of keeping at least one carry for a target - normally carry spawn rate won't get too fast because `Math.sqrt` is used

some improvement

3efe2b0

- fixed pickupWhileMoving. carry might move back and forth next to sourcer - ensureOne: exclude creeps that have `resetTarget` flag

TooAngel reviewed Sep 20, 2017

View reviewed changes

kahojyun closed this Dec 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] improve carry recycling #403

[WIP] improve carry recycling #403

kahojyun commented Sep 10, 2017 •

edited

Loading

samogot left a comment

samogot Sep 14, 2017

samogot Sep 14, 2017 •

edited

Loading

samogot Sep 14, 2017

kahojyun Sep 15, 2017

samogot Sep 15, 2017

samogot Sep 14, 2017

samogot Sep 14, 2017

kahojyun Sep 15, 2017

TooAngel Sep 10, 2017

kahojyun Sep 15, 2017

TooAngel Sep 20, 2017

TooAngel Sep 10, 2017

kahojyun Sep 15, 2017

TooAngel Sep 20, 2017

kahojyun Sep 15, 2017

TooAngel Sep 17, 2017

kahojyun Sep 21, 2017

TooAngel Sep 17, 2017

kahojyun Sep 18, 2017 •

edited

Loading

TooAngel Sep 20, 2017

TooAngel Sep 20, 2017

TooAngel Sep 20, 2017

TooAngel Sep 20, 2017

TooAngel Sep 20, 2017

Nevrdid commented Sep 21, 2017

[WIP] improve carry recycling #403

[WIP] improve carry recycling #403

Conversation

kahojyun commented Sep 10, 2017 • edited Loading

samogot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samogot Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kahojyun Sep 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nevrdid commented Sep 21, 2017

kahojyun commented Sep 10, 2017 •

edited

Loading

samogot Sep 14, 2017 •

edited

Loading

kahojyun Sep 18, 2017 •

edited

Loading