-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to lodash 3 and crossfilter 1.3.11 #38
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Gaetan Semet <[email protected]>
@stibbons thank you, I will look this over this weekend. @Paradox41 do me a favor and remind me :v |
Will do lol On Wed, Apr 8, 2015 at 2:51 AM, Tom Neyland [email protected]
|
"resolutions": { | ||
"crossfilter": "~1.3.0" | ||
} | ||
"name": "angular-dc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the indentation on this changed by mistake by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invasive jshint
Signed-off-by: Gaetan Semet <[email protected]>
Signed-off-by: Gaetan Semet <[email protected]>
Signed-off-by: Gaetan Semet <[email protected]>
Any update on this PR? |
@stibbons @pranspach @Paradox41 Tonight I started the process of reviewing outstanding PRs and getting this repository in line with what I consider to be current best-practices; I have not have time to fully review this PR yet. In general this PR looks good and the only reason I am hesitating on merging it is because old technical debt that is lacking test coverage, I aim to fully review this soon. |
update to "crossfilter": "~1.3.11 and "lodash": "~3.6.0"
Signed-off-by: Gaetan Semet [email protected]