Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to lodash 3 and crossfilter 1.3.11 #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gsemet
Copy link

@gsemet gsemet commented Apr 7, 2015

update to "crossfilter": "~1.3.11 and "lodash": "~3.6.0"

Signed-off-by: Gaetan Semet [email protected]

@TomNeyland
Copy link
Owner

@stibbons thank you, I will look this over this weekend.

@Paradox41 do me a favor and remind me :v

@willsoto
Copy link
Collaborator

willsoto commented Apr 8, 2015

Will do lol

On Wed, Apr 8, 2015 at 2:51 AM, Tom Neyland [email protected]
wrote:

@stibbons https://github.com/Stibbons thank you, I will look this over
this weekend.

@Paradox41 https://github.com/paradox41 do me a favor and remind me :v


Reply to this email directly or view it on GitHub
#38 (comment).

"resolutions": {
"crossfilter": "~1.3.0"
}
"name": "angular-dc",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the indentation on this changed by mistake by any chance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invasive jshint

gsemet added 2 commits May 4, 2015 14:22
Signed-off-by: Gaetan Semet <[email protected]>
Signed-off-by: Gaetan Semet <[email protected]>
@pranspach
Copy link

Any update on this PR?

@TomNeyland
Copy link
Owner

@stibbons @pranspach @Paradox41

Tonight I started the process of reviewing outstanding PRs and getting this repository in line with what I consider to be current best-practices; I have not have time to fully review this PR yet.

In general this PR looks good and the only reason I am hesitating on merging it is because old technical debt that is lacking test coverage, I aim to fully review this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants