Update to 1.21.4 #62
Update to 1.21.4 #62
Conversation
This resolves an warning
This resolves a warning
This is while Minestom/Minestom#2474 is waited on
The parental object already inherits from the interface
This causes a disconnection by the client as it expects the color to be a boolean? This will need further testing
The arrows were moving clientside and desyncing due to lingering velocity. This just removes the velocity after it has collided with a block
|
okay sword works, bow not |
|
yo uh, can u make this use consumable on sword items now instead of shield cuz shield is ahh 1.21.4+ now has third/first person animations for consumable block |
|
Hmm, yeah... |
|
hello, is this PR finished / usable on a production server? |
|
No, I'm currently struggeling getting the bow done, if you find a way, feel free to continue here |
|
Whats wrong with the bow? |
|
It doesn't shoot an arrow |
|
is everything apart from the bow working correctly as far as you know? |
|
@CodeDoctorDE |
src/main/java/io/github/togar2/pvp/entity/projectile/ThrownEnderpearl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/togar2/pvp/feature/explosion/VanillaExplosionSupplier.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/togar2/pvp/feature/food/VanillaFoodFeature.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/togar2/pvp/feature/food/VanillaFoodFeature.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/togar2/pvp/feature/food/VanillaFoodFeature.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/togar2/pvp/feature/food/VanillaFoodFeature.java
Outdated
Show resolved
Hide resolved
| player.setItemInHand(hand, stack.withAmount(stack.amount() - 1)); | ||
| } | ||
| } | ||
| // ItemStack leftOver = consumable.usingConvertsTo(); |
There was a problem hiding this comment.
I don't know, this method is no longer in there, i need to check if there are alternatives
There was a problem hiding this comment.
There doesn't seem to be, I wrote a method to get this manually since it doesn't have a lot of exceptions
There was a problem hiding this comment.
They replaced this with its own component afaik?
There was a problem hiding this comment.
It comes from the "use_remainder" component
src/main/java/io/github/togar2/pvp/feature/projectile/VanillaBowFeature.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/togar2/pvp/feature/projectile/VanillaTridentFeature.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review. Most of these changes are from the previous pr so credit to it. |
Based on #61 but I couldn't test it currently