Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to deepcell>0.12.7 requirement #57

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

WeisLeDocto
Copy link
Member

As detailed in #20, there might come a moment when the minimum requirement for the DeepCell library will need to be updated. However, this means integrating a mechanism for ensuring that users provide a correct DeepCell API token. All the details of what this entails are detailed in the linked issue.

This PR brings several changes enabling token integration in MyoFInDer:

  • Update __main__.py to ensure the application won't start without a proper DeepCell token provided (d1858a0)
  • Update Windows installer to include a field for registering a DeepCell token during installation (b7f6752)
  • Update the test suite to ensure no test runs without a valid DeepCell token (a9ad5d1)
  • Update GitHub Action workflows to build additional files related to the DeepCell token, and to register the token whenever needed during the build steps (8e281f0, 356f504)
  • Update the installation section of the online documentation to mention the need for a DeepCell API token

The integration of the DeepCell token in MyoFInDer is far from perfect, but this implementation meets the minimal requirements IMO.

Closes #20

@WeisLeDocto WeisLeDocto added the enhancement New feature or request label Sep 8, 2024
@WeisLeDocto WeisLeDocto self-assigned this Sep 8, 2024
@WeisLeDocto WeisLeDocto linked an issue Sep 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to deepcell>12.0.7 requirement
1 participant