Replace start_myofinder.bat with myofinder.exe
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will make it clear for users which file to download between myofinder.exe and myofinder.msi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the
start_myofinder.batscript has been distributed by themyofinder.msiinstaller, and used for starting MyoFInDer. To avoid the startup script to be modified by users, and to distribute an actual startup executable rather than a text file, this PR replaces thestart_myofinder.batscript with amyofinder.exeexecutable.The executable is built with
gcc, from themyofinder.cppsource file (added in 0d5f80a). It performs roughly the same actions asstart_myofinder.batdid, with some minor adjustments. The configuration file for the Advanced Installer application (config.aip) was modified accordingly (51a6613), as well as thebuild_windows_installer.ymlfile managing an automated GitHub workflow (5249656).start_myofinder.batwas removed from the repository (79fee1c). The documentation was updated so that users don't get confused betweenmyofinder.msiandmyofinder.exe, both located in thebin/folder (fcd55e5 and 1483d87).