Fixes in pyproject.toml
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic check of the version was causing all the runtime dependencies to be build dependencies. This was considerably slowing down the tests and editable installation builds.
Wrong combination of parameters in the setuptools section of pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two minor problems that were introduced in #32 when switching from
setup.pytopyproject.toml:pyproject.toml, that was requiring to install the module at build-time. It was fixed by making the project version a static field ofpyproject.toml(25f8430).python -m pip install -e .) was broken on Windows (still working on Linux, curiously). It was due to an incorrect combination of settings in the section ofpyproject.tomlmanaging setuptools options. It was fixed by editing the broken fields to a correct syntax (5dfec3e).