Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the test workflows #30

Merged
merged 7 commits into from
Dec 25, 2023
Merged

Conversation

WeisLeDocto
Copy link
Member

In #29, a test mode was added to the module MyoFInDer to make it initialize without fully running. This test mode was however only implemented, but not actually used anywhere.

This PR make use of the test mode in two of the three implemented test workflows. In test_python_package.yml, the tests on Windows now start MyoFInDer in test mode instead of just importing the module. On Linux and macOS, however, this is not possible in absence of a graphical environment. The correct configuration for running tests on these OS without a graphical environment might be added in future works.

In build_windows_installer.yml, a wheel of the latest version of MyoFInDer is now built, and installed by the start_myofinder.bat script. The installed version of the module is then started in test mode, on a Windows machine.

The tests conducted in the workflows are still pretty basic. In future works, a more comprehensive test suite should be added and ideally run on all the supported Python versions and platforms.

@WeisLeDocto WeisLeDocto added the enhancement New feature or request label Dec 25, 2023
@WeisLeDocto WeisLeDocto self-assigned this Dec 25, 2023
@WeisLeDocto WeisLeDocto merged commit 4279c2a into main Dec 25, 2023
14 checks passed
@WeisLeDocto WeisLeDocto deleted the feature/improve_test_workflows branch December 25, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant