Enable Keyboard Accessibility for Custom Menu Items via Option Component #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when adding custom items—such as a "Use current location" button—to the menu through the MenuList component, these items were not accessible via keyboard navigation, as they were not included in the loadOptions API response. This limited both accessibility and the user experience for any persistent, consumer-defined suggestions shown alongside API-sourced results (such as Google suggestions).
With this PR, we introduce support for adding custom, always-visible menu items using the Option component. Custom suggestions are now fully integrated into the menu's keyboard navigation flow, ensuring they are accessible and selectable via keyboard, regardless of API results. This approach also standardizes how both API-sourced and custom options are managed and rendered.
Key Benefits:
Improved accessibility: Custom menu items are now fully keyboard accessible.
Unified approach: All suggestions—custom and API-based—should now be added via the Option component, not directly through MenuList.
Enhanced flexibility: Easily integrate persistent actions or suggestions (such as "Use current location") while maintaining a consistent user experience.