Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] dont overwrite core models #33

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

TimoStahl
Copy link
Owner

No description provided.

@creecros
Copy link
Collaborator

creecros commented Mar 3, 2021

to be fair, I didnt override the model, I extended the model. just saying.

@TimoStahl
Copy link
Owner Author

Yes, you replaced the core model with a custom model, which extends the core model.
But only one plugin can replace a core model at a time, so its fine for one plugin, but not if you use multiple plugins.

@creecros
Copy link
Collaborator

creecros commented Mar 3, 2021

true that. no matter what route you take, there will still be compatibility issues with other plugins it seems, and I really don't have time to rewrite metamagik or groupassign...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants