Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No std #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

No std #40

wants to merge 6 commits into from

Conversation

hunhoffe
Copy link

Hello! I've created a no-std version of abomonation by using core2::io::Write and core2::io::Result from the core2 crate.

I am fairly new to rust and I am happy to rework my changes if there are any stylistic or other issues with the current implementation. I have not looked into creating a no-std version of the abomonation_derive crate at this time. Because of this, I removed the deprecation warning from unsafe_abomonate since I wasn't sure if I could make the deprecation warning feature dependent (e.g., warn for std, do not warn for no-std). I welcome suggestions for how to handle this more gracefully.

@frankmcsherry
Copy link
Member

Hi, I'm sorry for the delayed response.

The crate is .. in something of a holding pattern as Rust sorts out its undefined behavior definitions. It's almost certainly undefined at the moment, but afaict not easily fixed until Rust commits to some specific behavior ("fixed" could be either "deleted" or something better).

As such, I'm recommending folks who want to use it with modification fork it and make the modifications, as part of owning the uncertainty around UB. Happy to keep the PR open for the possibility of better days, but not eager to encourage investment when we don't know if it is EOLed. Sorry!

@hunhoffe
Copy link
Author

No problem! Thanks for the response, and I understand. I couldn't wait until Rust settles on undefined behavior patterns, and so I'd be happy if the PR could stick around so if other folks also can't wait they can have access to an interim solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants