Fix (u)int8
implicit char
conversion in stringstream
#5445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the implicit character conversion that occurs when writing a
(u)int8
value to astringstream
in the helper functionstd::string to_str(const T& value)
. By casting to(u)int32
, we avoid this conversion.This issue was discovered after encountering a
UnicodeDecodeError
when usingoperator<<
in the TileDB-Py API on a TileDB Array schema that contained a(u)int8
attribute. Both a minimal TileDB-Py reproduction and the original issue involving TileDB-SOMA now work as expected.[sc-61915]
TYPE: NO_HISTORY | BUG
DESC: Fix implicit character conversion in
to_str
by casting (u)int8 to (u)int32.