Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-2.27] Pin Python version in Windows CI. (#5441) #5442

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[Backport release-2.27] Pin Python version in Windows CI. (#5441) #5442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15075e0
Pin Python version in Windows CI.
teo-tsirpanis Feb 6, 2025
bc9d028
Do not use `py` launcher.
teo-tsirpanis Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ jobs:
uses: seanmiddleditch/gha-setup-ninja@v4
- name: Prevent vcpkg from building debug variants
run: python $env:GITHUB_WORKSPACE/scripts/ci/patch_vcpkg_triplets.py
- name: Install Python
uses: actions/setup-python@v5
with:
python-version: '3.12'

- name: Configure TileDB
shell: pwsh
Expand Down
6 changes: 3 additions & 3 deletions scripts/install-run-gcs-emu.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ if (!$RunTestbench) {
Write-Host "Installing Google Cloud Storage Testbench..."
git clone --branch $version --depth 1 https://github.com/googleapis/storage-testbench.git $testbenchPath
Write-Host "Setting up Python virtual environment..."
py -m venv $venvPath
python -m venv $venvPath
& $venvPath\Scripts\activate
py -m pip install -e $testbenchPath
python -m pip install -e $testbenchPath
}
}

Expand All @@ -53,7 +53,7 @@ $env:CLOUD_STORAGE_EMULATOR_ENDPOINT = "http://localhost:9000"
# Run the testbench
& $venvPath\Scripts\activate
# $testbenchCmd = "start `"Google Cloud Storage Testbench`" py testbench_run.py localhost 9000 10"
$testbenchCmd = "start `"Google Cloud Storage Testbench`" /D `"$testbenchPath`" py testbench_run.py localhost 9000 10"
$testbenchCmd = "start `"Google Cloud Storage Testbench`" /D `"$testbenchPath`" python testbench_run.py localhost 9000 10"
cmd /c $testbenchCmd

# Wait for the testbench to be prepared. This was added to fix failures in the windows-2019-gcs job.
Expand Down
Loading