Skip to content

Conversation

teo-tsirpanis
Copy link
Member

No description provided.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review October 9, 2025 17:44
@teo-tsirpanis teo-tsirpanis requested a review from shaunrd0 October 9, 2025 17:44
Copy link
Member

@shaunrd0 shaunrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

<DiagnosticId>PKV006</DiagnosticId>
<Target>net5.0</Target>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:TileDB.CSharp.ConfigIterator</Target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use these options instead of doing this manually? No worries if not, just checking after looking through the docs this morning

https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#apicompatgeneratesuppressionfile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how I generated this file; with a dotnet pack -p:ApiCompatGenerateSuppressionFile=true. 😅

The file is supposed to be committed to source control and manually regenerated, in order to catch inadvertent breaking changes to the API. These changes were made earlier in #363, but the compatibility file got updated now because we delayed bumping the version.

@teo-tsirpanis teo-tsirpanis merged commit e00d126 into TileDB-Inc:main Oct 15, 2025
4 checks passed
@teo-tsirpanis teo-tsirpanis deleted the update-2.29 branch October 15, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants