-
Notifications
You must be signed in to change notification settings - Fork 5
Update Core to 2.29. #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Core to 2.29. #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
<DiagnosticId>PKV006</DiagnosticId> | ||
<Target>net5.0</Target> | ||
<DiagnosticId>CP0001</DiagnosticId> | ||
<Target>T:TileDB.CSharp.ConfigIterator</Target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use these options instead of doing this manually? No worries if not, just checking after looking through the docs this morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how I generated this file; with a dotnet pack -p:ApiCompatGenerateSuppressionFile=true
. 😅
The file is supposed to be committed to source control and manually regenerated, in order to catch inadvertent breaking changes to the API. These changes were made earlier in #363, but the compatibility file got updated now because we delayed bumping the version.
No description provided.