Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index UI #8840

Open
wants to merge 5 commits into
base: multi-wiki-support
Choose a base branch
from
Open

Conversation

well-noted
Copy link
Contributor

Current implementation sets the bags as reverse-order-entry for creating or modifying recipes. Reverses retrieval to be consistent with natural language entry.

Copy link

Confirmed: well-noted has already signed the Contributor License Agreement (see contributing.md)

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for tiddlywiki-previews failed.

Name Link
🔨 Latest commit ea1c31f
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/67676fa33f53850008a8ac2c

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @well-noted the contents of this PR appears to be the delete bag/recipe PR in #8822 and doesn't relate to the description.

I also notice that there are some whitespace changes in SqlTiddlerStore.prototype.processIncomingTiddler which make it difficult to track any material changes.

@pmario
Copy link
Member

pmario commented Dec 23, 2024

@well-noted -- As Jeremy pointed out, that this PR contains more than just the fix as described in the OP.

It also seems that some tests fail now -- Which can happen, if "filter order" is changed.
So the PR should also contain the code to "fix" the tests. -- All the tests have to be re-evaluated, if they still match the requirements. New tests have to be added if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants