[pull] master from marioortizmanero:master #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Using flags as parameters is misleading because it seems as if more than one flags can be passed at once. This is not the case, so actions are more suitable. Also renamed printHelp to usage because it's more widely used.
Add bash minimum version to readme
Fix shebang
If the user has `dunstify` installed we should replace old notifications instead of letting them accumulate in the notification center.
Occasionally, an integer value of 100, in addition of the active volume level, is returned which breaks all conditional statements where an integer expression is expected.
Make sure only one integer value is returned
marioortizmanero
force-pushed
the
master
branch
from
6ef7437
to
5237438
Compare
For example:
polybar-pulseaudio-control --sink-icon='⇉ ' \
--sink-name-from='device.description' --vol-icon-low='🔈 ' \
--vol-icon-mid='🔉 ' --vol-icon-high='🔊 ' listen
Towards #26.
Note that this is a change in behaviour - previously the `--output` was incorrect and the usage was displayed as though an error but it was ignored. It seems clear that the intention was the `output` subcommand, so I've left that in rather than remove it, or change the `--`-parsing behaviour to exit with status 0 on a bad argument in order to continue to allow it. I've also changed it to a single line output instead of the full `usage` - since this makes it clearer what's wrong in polybar, where it may occur if typo'd in config, for example.
Previously a newly connected device wouldn't have its prop read.
Before this commit, pulseaudio-control supported solely sinks. After this commit, it supports sinks and sources, under a new name "node". A new flag `--node-type` changing the behavior of the script to handle sources instead of sinks. All the existing mentions of sinks have been changed to node when appropriate. Sinks and sources almost share the same commands, with the main difference being the command name (i.e. sink for Sinks). Thus, this commit adds a simple and hacky way to handle sources: a variable SINK_OR_SOURCE holds either `ink` or `ource` so that commands that were using `Sink` `Sinks` `sinks` `sink` can be transformed to `Source` `Sources` `sources` `source` easily.
Sometimes, only the client event is present, to be safe, update when it's triggered.
Add support for sources (microphone)
Temporary fix to high CPU load
Add --listen-timeout-secs
add option to disable color muted
quotes prevent glob and word splitting + typos
…s needed by the polybart module.
refactor: rename 'pulseaudio-control.bash' to 'pulseaudio-control', as needed by the polybar module.
When the port is something like "[Out] Speaker" the previous awk call only extracted "[Out]". Co-authored-by: Nicolas Chachereau <[email protected]>
Port stripped on white space (e.g., [Out] Speaker)
previously an empty value passed via --color-muted resulted in a broken COLOR_MUTED. Now it's just an empty string.
fix empty color muted from command line
Fixes regression introduced in 4e5995e.
Fix regression in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )