Unset argument detail before calling callback #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandervoord
approved these changes
Jul 4, 2025
| @@ -96,6 +96,7 @@ | |||
| function = {:name => "Apple", :args => [], :args_string => "void", :return => test_return[:void]} | |||
| expected = [" if (Mock.Apple_CallbackFunctionPointer != NULL)\n", | |||
| " {\n", | |||
| " UNITY_SET_DETAIL(CMockString_#{function[:name]});\n", | |||
There was a problem hiding this comment.
:) Thanks for updating the tests too!
|
Thanks, @ml-physec -- We appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍍
As the callback is called after validating the last argument, but before CLR_DETAILS, the detail is still set to function+last argument, leading to confusing output.
This changes it so the argument name is cleared before calling the callback.
For stubs, no change is needed, as those are called before the arguments, so just the function name is already set at that point.