-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'multipart/form-data' support for file uploads #1372
base: develop
Are you sure you want to change the base?
Conversation
Hi zenghao! Why did you revert the changes by reverting commit? Could you Sync fork please? There is no develop branch in the forked repo! |
@myall200 Hi Zenghao! I hope, if we will have a pair programming sessions together, we could deliver full functioning feature and the PR could close the list of open issues. Happy Friday! |
add multipart/form-data support
This reverts commit 72cb5e6.
…readability. Replace with `string.Contains`
…od, or static field initializer
…e blank lines preceding this brace
The feature branch (master) has been rebased onto ThreeMammals:develop! I don't see develop branch in your fork! Your fork is too old. Could you Sync fork please? So, new develop branch will occur with all top commits! Could you add me as collaborator to your forked repo please? I will create develop branch and make it default. There are 2 failed tests in the build: Fully qualified names:
Reason: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$\color{red}{There\ are\ 2\ failed\ tests\ in\ the\ build!}$
Build: 1422
@myall200 Hello Zenghao,
Regarding the proposed changes, it appears we resolved the form data forwarding issue a year ago. I will mark the PR as a draft until you create a new one. Subsequently, I will determine further actions, but your prompt feedback would be appreciated. |
Fixes #714
Motivation
Introduce a support of file streaming (file uploads) via the gateway, without body content caching.
Current loading of entire body to a memory in Ocelot core is a source of errors, unstable responses because downstream services produce errors during long lasting operation of the request.
Proposed Changes
multipart/form-data
support for file uploadsRelated to