Fixed #65 Cannot replace root elements in html-fragment

ThomasWeinert · Mar 3, 2017 · 7172b4b · 7172b4b
1 parent ebf5c45
commit 7172b4b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/FluentDOM/Node/ChildNode/Implementation.php b/src/FluentDOM/Node/ChildNode/Implementation.php
@@ -27,7 +27,10 @@ public function remove() {
     public function before($nodes) {
       /** @var \DOMNode|Implementation $this */
       if (
-        $this->parentNode instanceof \DOMElement &&
+        (
+          $this->parentNode instanceof \DOMElement ||
+          $this->parentNode instanceof \DOMDocument
+        ) &&
         ($nodes = MutationMacro::expand($this->ownerDocument, $nodes))
       ) {
         $this->parentNode->insertBefore($nodes, $this);
@@ -42,7 +45,10 @@ public function before($nodes) {
     public function after($nodes) {
       /** @var \DOMNode|Implementation $this */
       if (
-        $this->parentNode instanceof \DOMElement &&
+        (
+          $this->parentNode instanceof \DOMElement ||
+          $this->parentNode instanceof \DOMDocument
+        ) &&
         ($nodes = MutationMacro::expand($this->ownerDocument, $nodes))
       ) {
         if ($this->nextSibling instanceof \DOMNode) {

diff --git a/tests/FluentDOM/Node/ChildNodeTest.php b/tests/FluentDOM/Node/ChildNodeTest.php
@@ -74,5 +74,19 @@ public function testReplaceWithElementNode() {
         $dom->saveXML()
       );
     }
+
+    /**
+     * @covers \FluentDOM\Node\ChildNode\Implementation
+     */
+    public function testReplaceWithDocumentElement() {
+      $dom = new Document();
+      $dom->loadXML('<foo><bar/></foo>');
+      $newNode = $dom->createElement('replaced');
+      $dom('/foo')->item(0)->replace($newNode);
+      $this->assertXmlStringEqualsXmlString(
+        '<replaced/>',
+        $dom->saveXML()
+      );
+    }
   }
 }