Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Comparisons #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Date Comparisons #19

wants to merge 3 commits into from

Conversation

robmarti
Copy link

This PR should fix some date related issues.

Adjust DateTime related grammar parts:

  • use the dayjs format() function which returns an ISO8601 (allows for lexicographical comparison between dates)
  • pass the correct substring to dayjs (previously, the last character of date strings was omitted)

Adjust evaluation logic:

  • allow for inequality checks between non-numerical types

@mikepringle
Copy link

mikepringle commented Dec 18, 2024

@ThomasHambach is it possible to get this updated and merged in? Looks like you need to migrate from SonarCloud to sonarqube-scan-action.

@ThomasHambach
Copy link
Owner

@mikepringle yes! Been a bit swamped at the full time job. I would be happy if you have the time for a PR, if not I can do it over the weekend.

@mikepringle
Copy link

mikepringle commented Dec 19, 2024

PR is up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants