Review/fix validation of image without checksum #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match These counts can help to diagnose and identify problems during development. Signed-off-by: Patrick Rouleau <[email protected]>
Signed-off-by: Patrick Rouleau <[email protected]>
When the image does not use a checksum, it is validated with custom code. Some file systems do not report the same used block count than what partclone find while he build the used bitmap. We must use the count from the bitmap because the clone and restore are based solely on the bitmap. Signed-off-by: Patrick Rouleau <[email protected]>
|
Sorry, this pull request is too old. Please update it again if necessary, or I will turn off this request in the future. Please forgive me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serie fix the issue #50.
I added some log_mesg() to help to diagnose what we get in the image.
However, the checksum of the restored ext4 file system is not identical to the cloned one, when it is run on a 32 bits host. The original file system contains some bits that are not taken into account in bitmap. The log contains some messages likes: "extfsclone.c: BLOCK_UNINIT for group 2". This is also the case on the release branch (ie it was not introduced by the "format 0002").