fix(core): camera: fix mirroring in landscape with front facing camera

ThibaultBee · Jan 21, 2025 · 7b857ce · 7b857ce
1 parent 7920b7b
commit 7b857ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/...io/github/thibaultbee/streampack/core/elements/sources/video/camera/CameraInfoProvider.kt b/...io/github/thibaultbee/streampack/core/elements/sources/video/camera/CameraInfoProvider.kt
@@ -44,7 +44,8 @@ class CameraInfoProvider(
     val isFrontFacing: Boolean
         get() = context.getFacingDirection(cameraId) == CameraCharacteristics.LENS_FACING_FRONT
 
-    override val isMirror = false
+    override val isMirror: Boolean
+        get() = isFrontFacing
 
     @IntRange(from = 0, to = 359)
     override fun getRelativeRotationDegrees(

diff --git a/.../main/java/io/github/thibaultbee/streampack/core/streamers/single/CameraSingleStreamer.kt b/.../main/java/io/github/thibaultbee/streampack/core/streamers/single/CameraSingleStreamer.kt
@@ -153,10 +153,6 @@ open class CameraSingleStreamer(
         return CameraStreamerConfigurationInfo(endpointInfo)
     }
 
-    override fun isMirroringRequired(): Boolean {
-        return cameraSource.infoProvider.isFrontFacing
-    }
-
     /**
      * Sets a preview surface.
      */