Skip to content

Commit

Permalink
Disable sync validation for now.
Browse files Browse the repository at this point in the history
It's broken with timeline semaphores.
  • Loading branch information
Themaister committed Jun 20, 2024
1 parent 4c42a91 commit be6ed2f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions vulkan/context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,8 @@ bool Context::create_instance(const char * const *instance_ext, uint32_t instanc
std::vector<VkExtensionProperties> layer_exts(layer_ext_count);
vkEnumerateInstanceExtensionProperties("VK_LAYER_KHRONOS_validation", &layer_ext_count, layer_exts.data());

#if 0
// Tons of false positives around timeline semaphores atm, so don't bother.
if (find_if(begin(layer_exts), end(layer_exts), [](const VkExtensionProperties &e) {
return strcmp(e.extensionName, VK_EXT_VALIDATION_FEATURES_EXTENSION_NAME) == 0;
}) != end(layer_exts))
Expand All @@ -657,6 +659,7 @@ bool Context::create_instance(const char * const *instance_ext, uint32_t instanc
validation_features.pEnabledValidationFeatures = validation_sync_features;
info.pNext = &validation_features;
}
#endif

if (!ext.supports_debug_utils &&
find_if(begin(layer_exts), end(layer_exts), [](const VkExtensionProperties &e) {
Expand Down

0 comments on commit be6ed2f

Please sign in to comment.