MaxBreadcrumbs setting & fix README #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At first, I wanted only to update the instruction. But when I made breadcrumbs work in my real-world application, I noticed that 1000 breadcrumbs is too much as a reasonable default value. I changed the value down to 100 and added a new MaxBreadcrumbs setting. |
SladeThe
changed the title
|
hi, you're completely right. we should attach zapscope to our core not original. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log = log.With(zapsentry.NewScope())is actually a no-op operation, if called before attachingzapsentrycore.The existing
zapcore ignores it silently. The order does matter.Another option is to update the
zapsentrycore itself:core = core.With([]zap.Field{zapsentry.NewScope()})