Add exceptions from errors #20
Conversation
|
@grongor hi, sorry for delay. could you rebase or merge master? there are some conflicts |
|
@TheZeroSlave np, I'll look into it tomorrow |
Also some related refactoring of the core
|
@TheZeroSlave done |
|
@TheZeroSlave hey, soooo...let's do this? :D |
|
@grongor hey, sorry for absent. will check in couple of days |
| Value: ent.Caller.TrimmedPath(), | ||
| Stacktrace: trace, | ||
| }} | ||
| if event.Exception == nil && !c.cfg.DisableStacktrace && c.client.Options().AttachStacktrace { |
There was a problem hiding this comment.
we skip it for exceptions because it already contains stacktrace?
There was a problem hiding this comment.
Yes. I don't think it makes sense to create an artificial stack trace from "another place" when we already have one which is as exact as can be.
|
|
||
| func (c *core) addExceptionsFromError( | ||
| exceptions []sentry.Exception, | ||
| processedErrors map[error]struct{}, |
There was a problem hiding this comment.
i see no references to "processedErrors" outside this function. should it really be passed as argument?
There was a problem hiding this comment.
It is shared between invocations, so yes. Its used to de-duplicate the errors.
Also some related refactoring of the core