fix(android): report track selection in onTextTracks/onAudioTracks with controls#4920
Open
janpe wants to merge 1 commit into
Open
fix(android): report track selection in onTextTracks/onAudioTracks with controls#4920janpe wants to merge 1 commit into
janpe wants to merge 1 commit into
Conversation
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4918.
With
controlsenabled on Android,onTextTracks/onAudioTracksreported every track asselected: false(regression since 6.16.0 / #4581). Before that migration,onTracksChangedalways used the selection-aware getters regardless ofcontrols; #4581 added acontrolsbranch that hard-codedselected = false("let PlayerView handle it"). But these are data callbacks —PlayerViewrendering the native picker doesn't replace reporting selection to JS.Changes
Compute
selectedfromplayer.getCurrentTrackSelections()ingetBasicTextTrackInfo/getBasicAudioTrackInfo, reusing the controls-off logic (getAudioTrackInfo/getTextTrackInfo). Restores the pre-#4581 behavior; matches controls-off and iOS.Test plan
Play an HLS stream with multiple audio/subtitle tracks and
controlsenabled, switch tracks via the native picker, and confirmonTextTracks/onAudioTracksreport the active track asselected: true.