Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to globally and per-player disable internal audio session management on iOS, allowing other libraries (such as audio recording libraries) to control the AVAudioSession without interference from react-native-video. The implementation is iOS-specific and is a no-op on Android. The changes include new APIs, property additions, and updates to the native and TypeScript layers.
iOS Audio Session Management Control:
setAudioSessionManagementDisabledto allow disabling or enabling internal audio session management from JavaScript, exposed via theVideoPlayerFactoryinterface and implemented in both Swift and TypeScript. [1] [2] [3] [4] [5]VideoManagerin Swift to support both a global flag and per-player flags for disabling audio session management, ensuring that AVAudioSession is only controlled if management is enabled. [1] [2] [3]disableAudioSessionManagementto theHybridVideoPlayerclass on iOS, with logic to trigger audio session updates when changed.TypeScript/JS API and Typings:
disableAudioSessionManagementproperty on theVideoPlayerBaseTypeScript interface and implemented corresponding getter/setter logic in theVideoPlayerclass, including developer warnings for unsupported platforms. [1] [2]setAudioSessionManagementDisabledutility from the main module entry point for easy access.Android Compatibility:
Developer Experience:
These changes make it easier to integrate react-native-video with other audio-related libraries on iOS by providing fine-grained control over AVAudioSession management.