fix(ios): fixed audio focus change on iOS#4811
Merged
moskalakamil merged 2 commits intoTheWidlarzGroup:masterfrom Mar 9, 2026
Merged
fix(ios): fixed audio focus change on iOS#4811moskalakamil merged 2 commits intoTheWidlarzGroup:masterfrom
moskalakamil merged 2 commits intoTheWidlarzGroup:masterfrom
Conversation
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
Contributor
|
is this connected to some reported issue somewhere? |
Contributor
Author
|
no i was just playing with the example app and found this issue |
Contributor
|
by any chance it might fix this? #4810 |
Contributor
Author
|
This issue doesn't occur here. |
There was a problem hiding this comment.
Pull request overview
Fixes iOS audio session category option handling so switching MixAudioMode values doesn’t leave stale AVAudioSession.CategoryOptions flags set.
Changes:
- Always clears
.duckOthersand.mixWithOthersbefore applying the newly determined mixing mode. - Simplifies the
switchby combining the “no-op” modes (.auto,.donotmix) into a single case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
moskalakamil
approved these changes
Mar 9, 2026
github-project-automation
Bot
moved this from To Triage
to Done
in React Native Video - Public Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation of audio mixing mode selection had a bug where switching between different modes (e.g., from .mixWithOthers to .doNotMix) did not consistently remove the previously set options. This was because the switch statement only handled removals in specific cases, potentially leaving stale flags in audioSessionCategoryOptions.