Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init settings bug fix #363

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Init settings bug fix #363

merged 2 commits into from
Aug 12, 2023

Conversation

MattEqualsCoder
Copy link
Collaborator

Fixes a few things

  1. The options window would not actually create the output directory, meaning if someone closed and reopened before generating a rom it would ask to update settings again
  2. It never validated the options when closing the options window, so people wouldn't know if they missed required fields
  3. It would never show the rom list/generate button after updating the options initially, meaning people would be stuck in a loop unless they selected a, output folder that already exists

@MattEqualsCoder MattEqualsCoder merged commit 60f963f into main Aug 12, 2023
1 check passed
@MattEqualsCoder MattEqualsCoder deleted the init-settings-bug-fix branch August 12, 2023 04:39
@MattEqualsCoder MattEqualsCoder linked an issue Aug 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMZ3 Singleplayer Tab is Blank on Fresh Installs
3 participants