Skip to content

Conversation

eadadi
Copy link

@eadadi eadadi commented Sep 23, 2024

Motivation

Sometimes we need to make modifications to the suggested prompt before executing it.
This patch adds [M]odify option to the suggested prompt

@eadadi
Copy link
Author

eadadi commented Feb 28, 2025

is it going to be merged/checked/anything?

@TheR1D
Copy link
Owner

TheR1D commented Apr 11, 2025

Hello @eadadi, thank you for your contibution. It is a great feature, but It is a bit problematic to check new PRs that are not fully following contribution requirements. Could you please make sure the existing tests and linting tools are passing and add at least one more test in order to test new feature (if possible).

@TheR1D TheR1D added the enhancement New feature or request label Apr 11, 2025
eadadi and others added 2 commits April 11, 2025 14:20
@eadadi
Copy link
Author

eadadi commented Apr 11, 2025

Ok, I have modified the tests to reflect the change.
In addition, I separated the modify to - modify comand [M] and modify and run command [R]. It is better to have both in my opinion.
And using only [M] allows further interaction with the AI - to description with respect to the modified command for example

@eadadi
Copy link
Author

eadadi commented Apr 11, 2025

Also, tests and lint are passing

@eadadi
Copy link
Author

eadadi commented Apr 15, 2025

@TheR1D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants