Skip to content

Conversation

@goran1010
Copy link
Contributor

Because

This lesson required a few changes to bring it close (but not completely) up to date to the current style guide.

This PR

  • Fix formatting of the ordered list
  • Add Lesson overview, Knowledge check and Additional resources sections
  • Change a superfluous heading to a sentence and move it to an appropriate paragraph

Additional Information

This lesson will still contain a TOP004 styling rule issue because it lacks an Assignment section.
But as discussed in another PR, it's probably more appropriate to not have an Assignment section at all, rather than an empty one -- and since there are no links or articles in this lesson, there is really no content to put in it.

So while other lint issues have been fixed, and the structure of the lesson is brought up to speed, there will still be that one rule violation.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Getting Hired Involves the Getting Hired course label Oct 22, 2025
@mao-sz
Copy link
Contributor

mao-sz commented Oct 23, 2025

Hmmm, similar to the installation lessons, the lesson heading structure feels a little off for these "How the course will work" lessons. I'll put this one on hold and bring this up with the team (since we already have the installations lessons in our backlog of heating structure stuff).

@mao-sz mao-sz added the Status: Do Not Merge This PR should not be merged until further notice label Oct 23, 2025
@mao-sz
Copy link
Contributor

mao-sz commented Nov 17, 2025

Closing due to #30369 (comment)

@mao-sz mao-sz closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: Getting Hired Involves the Getting Hired course Status: Do Not Merge This PR should not be merged until further notice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants